Skip to content

protobuf: switch to cmake#122277

Closed
paperchalice wants to merge 1 commit intoHomebrew:masterfrom
paperchalice:protobuf
Closed

protobuf: switch to cmake#122277
paperchalice wants to merge 1 commit intoHomebrew:masterfrom
paperchalice:protobuf

Conversation

@paperchalice
Copy link
Copy Markdown
Contributor

@paperchalice paperchalice commented Feb 4, 2023

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Upstream removed all autotools usage. See protocolbuffers/protobuf#10132.

@carlocab carlocab added CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Feb 4, 2023
@BrewTestBot
Copy link
Copy Markdown
Contributor

BrewTestBot commented Feb 4, 2023

🤖 A scheduled task has triggered a merge.

@rst0git
Copy link
Copy Markdown

rst0git commented Feb 5, 2023

The changes in this commit are causing the following build error with find_package (Protobuf 3.0.0 REQUIRED):

-- Found BISON: /usr/local/opt/bison/bin/bison (found suitable version "3.8.2", minimum required is "3.0") 
CMake Error at /usr/local/Cellar/cmake/3.25.2/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:[23](https://github.com/p4lang/p4c/actions/runs/4092947659/jobs/7065731355#step:5:24)0 (message):
  Could NOT find Protobuf (missing: Protobuf_LIBRARIES) (found suitable
  version "3.21.12", minimum required is "3.0.0")
-- Configuring incomplete, errors occurred!
Call Stack (most recent call first):
See also "/Users/runner/work/p4c/p4c/build/CMakeFiles/CMakeOutput.log".
  /usr/local/Cellar/cmake/3.[25](https://github.com/p4lang/p4c/actions/runs/4092947659/jobs/7065731355#step:5:26).2/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
See also "/Users/runner/work/p4c/p4c/build/CMakeFiles/CMakeError.log".
  /usr/local/Cellar/cmake/3.25.2/share/cmake/Modules/FindProtobuf.cmake:650 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  CMakeLists.txt:117 (find_package)

@kou kou mentioned this pull request Feb 14, 2023
Merged
@rst0git rst0git mentioned this pull request Feb 16, 2023
Merged
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 8, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2023
@paperchalice paperchalice deleted the protobuf branch June 25, 2023 00:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chenrui333 chenrui333 chenrui333 approved these changes

Assignees

No one assigned

Labels

CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. outdated PR was locked due to age

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@paperchalice @BrewTestBot @rst0git @chenrui333 @carlocab