Skip to content

ansible 7.1.0 ansible 6.7.0 (new formula)#116476

Closed
chenrui333 wants to merge 2 commits into
Homebrew:masterfrom
chenrui333:bump-ansible-7.0.0
Closed

ansible 7.1.0 ansible 6.7.0 (new formula)#116476
chenrui333 wants to merge 2 commits into
Homebrew:masterfrom
chenrui333:bump-ansible-7.0.0

Conversation

@chenrui333

@chenrui333 chenrui333 commented Nov 23, 2022

Copy link
Copy Markdown
Member

Created by brew bump

Created with brew bump-formula-pr.

@BrewTestBot BrewTestBot added automerge-skip `brew pr-automerge` will skip this pull request bump-formula-pr PR was created using `brew bump-formula-pr` labels Nov 23, 2022
@dawidd6

dawidd6 commented Nov 23, 2022

Copy link
Copy Markdown
Contributor

Should we also provide ansible@6 formula right now? Ansible 6 is still supported.

@chenrui333

chenrui333 commented Nov 23, 2022

Copy link
Copy Markdown
Member Author

Works for me, adding a ansible@6 as well

@chenrui333 chenrui333 changed the title ansible 7.0.0 ansible 7.0.0 ansible 6.6.0 (new formula) Nov 23, 2022
@chenrui333

chenrui333 commented Nov 23, 2022

Copy link
Copy Markdown
Member Author

added a placeholder disable line to reminder to disable after 6.7.0 release

p-linnane
p-linnane reviewed Nov 23, 2022
View reviewed changes
Comment thread Formula/ansible@6.rb Outdated
@chenrui333 chenrui333 added the long build Set a long timeout for formula testing label Nov 24, 2022
SMillerDev
SMillerDev reviewed Nov 24, 2022
View reviewed changes
Comment thread Formula/ansible@6.rb Outdated
@Bo98

Bo98 commented Nov 26, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

added a placeholder disable line to reminder to disable after 6.7.0 release

Note that our minimum deprecation period before disabling is 3 months (otherwise there's no point shipping a 6.7.0 if it's disabled immediately and people can't upgrade), and the 6.7.0 release is coming I think next week.

@chenrui333

chenrui333 commented Nov 26, 2022

Copy link
Copy Markdown
Member Author

added a placeholder disable line to reminder to disable after 6.7.0 release

Note that our minimum deprecation period before disabling is 3 months (otherwise there's no point shipping a 6.7.0 if it's disabled immediately and people can't upgrade), and the 6.7.0 release is coming I think next week.

yeah, that is what I was thinking to add disable ansible@6 at a future time.

@github-actions

github-actions Bot commented Nov 28, 2022

Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions Bot added the stale No recent activity label Nov 28, 2022
@p-linnane p-linnane added in progress Stale bot should stay away and removed stale No recent activity labels Nov 28, 2022
@chenrui333 chenrui333 added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Nov 28, 2022
@cho-m

cho-m commented Nov 28, 2022

Copy link
Copy Markdown
Member

Not sure if we want to add a quick fix for #115922 by downgrading openstacksdk resource and locking in version within pypi_formula_mappings.json. Looks like 7.0.0 is also max bounded:

❯ rg 'MAXIMUM_SDK_VERSION =' ansible-7.0.0/ansible_collections/openstack/cloud/plugins/module_utils/openstack.py
80:MAXIMUM_SDK_VERSION = '0.98.999'

❯ rg 'MAXIMUM_SDK_VERSION =' ansible-6.6.0/ansible_collections/openstack/cloud/plugins/module_utils/openstack.py
80:MAXIMUM_SDK_VERSION = '0.98.999'

A followup discussion/fix may be needed on how we want to handle Ansible plugins as we aren't able to track/maintain these well. It is possible that some of the resources may be no longer used, but it is hard to tell as we use extra_packages.

Based on https://opendev.org/openstack/ansible-collections-openstack#breaking-backward-compatibility-warning, there is a separate release series for newer openstacksdk but doesn't seem ready yet.

@chenrui333 chenrui333 removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Nov 28, 2022
SMillerDev
SMillerDev previously approved these changes Dec 15, 2022
View reviewed changes
@cho-m cho-m added the new formula PR adds a new formula to Homebrew/homebrew-core label Dec 16, 2022
@tony-sol

tony-sol commented Dec 21, 2022

Copy link
Copy Markdown
Contributor

Isn't it ready for merge?

chenrui333 and others added 2 commits December 24, 2022 00:32
@chenrui333
ansible 7.1.0
e81d33a 
Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333 @p-linnane
ansible@6 6.7.0 (new formula)
8c30af7 
ansible@6: fix typo

Co-authored-by: Patrick Linnane <patrick@linnane.io>
Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333 chenrui333 added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Dec 24, 2022
@chenrui333 chenrui333 changed the title ansible 7.0.0 ansible 6.6.0 (new formula) ansible 7.1.0 ansible 6.7.0 (new formula) Dec 24, 2022
@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Dec 24, 2022
@chenrui333

chenrui333 commented Dec 24, 2022

Copy link
Copy Markdown
Member Author

Updating to ansible 7.1.0 and ansible@6 6.7.0 and making the final run.

@iMichka iMichka removed the automerge-skip `brew pr-automerge` will skip this pull request label Dec 24, 2022
@BrewTestBot

BrewTestBot commented Dec 24, 2022

Copy link
Copy Markdown
Contributor

:shipit: @iMichka has triggered a merge.

@iMichka iMichka added automerge-skip `brew pr-automerge` will skip this pull request and removed CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. labels Dec 24, 2022
@chenrui333 chenrui333 deleted the bump-ansible-7.0.0 branch December 24, 2022 14:39
@github-actions github-actions Bot added the outdated PR was locked due to age label Jan 24, 2023
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jan 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@p-linnane p-linnane p-linnane left review comments

@iMichka iMichka iMichka approved these changes

@SMillerDev SMillerDev SMillerDev left review comments

Assignees

No one assigned

Labels

automerge-skip `brew pr-automerge` will skip this pull request bump-formula-pr PR was created using `brew bump-formula-pr` in progress Stale bot should stay away long build Set a long timeout for formula testing new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age ready to merge PR can be merged once CI is green

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@chenrui333 @dawidd6 @Bo98 @cho-m @tony-sol @BrewTestBot @SMillerDev @iMichka @p-linnane