minimal-racket: use openssl@3#115930
Conversation
| patch :p2, :DATA | ||
|
|
There was a problem hiding this comment.
No, it's not. The purpose of the patch is to move the version 3 string to the top so it will be found first.
There was a problem hiding this comment.
And why don't we want to upstream that?
There was a problem hiding this comment.
Sorry, I didn't see your comment the last time I check this pr. The official Racket installer ships openssl 1.1 for macOS, I don't think they would move version 3 before 1.1.
| (let | ||
| ([versions | ||
| - '("1.1" | ||
| + '(;; OpenSSL 3 works for most functionality: |
There was a problem hiding this comment.
What does this mean by "most" functionality?
There was a problem hiding this comment.
https://racket.discourse.group/t/ubuntu-22-04-libssl-3-migration/942/2 mentions some tests failed.
There was a problem hiding this comment.
I run the tests and all openssl tests including the three tests mflatt mentioned on discourse passed.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
LGTM |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?