qdae: fix build with glibc 2.35 and deprecate#111515
Closed
cho-m wants to merge 1 commit intoHomebrew:masterfrom
Closed
qdae: fix build with glibc 2.35 and deprecate#111515cho-m wants to merge 1 commit intoHomebrew:masterfrom
cho-m wants to merge 1 commit intoHomebrew:masterfrom
Conversation
7a4250e to
075d481
Compare
cho-m
commented
Sep 23, 2022
Comment on lines
+29
to
+34
| # Fix build failure with newer glibc: | ||
| # /usr/bin/ld: ../lib/.libs/libdsk.a(drvlinux.o): in function `linux_open': | ||
| # drvlinux.c:(.text+0x168): undefined reference to `major' | ||
| # /usr/bin/ld: ../lib/.libs/libdsk.a(compress.o): in function `comp_open': | ||
| # compress.c:(.text+0x268): undefined reference to `major' | ||
| ENV.append_to_cflags "-include sys/sysmacros.h" if OS.linux? |
Member
Author
There was a problem hiding this comment.
Could alternatively use patch/inreplace to add #include <sys/sysmacros.h>. Just trying simplest option since doesn't seem to be maintained.
SMillerDev
approved these changes
Sep 23, 2022
Contributor
|
🤖 A scheduled task has triggered a merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?