Skip to content

python@3.9: avoid shelling out to brew#107695

Merged
carlocab merged 1 commit intoHomebrew:masterfrom
carlocab:setuptools-workaround
Aug 10, 2022
Merged

python@3.9: avoid shelling out to brew#107695
carlocab merged 1 commit intoHomebrew:masterfrom
carlocab:setuptools-workaround

Conversation

@carlocab
Copy link
Copy Markdown
Member

This breaks builds inside superenv. See


  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@carlocab carlocab added CI-no-bottles Merge without publishing bottles CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. labels Aug 10, 2022
@BrewTestBot BrewTestBot added the legacy Relates to a versioned @ formula label Aug 10, 2022
@cho-m cho-m added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. long build Set a long timeout for formula testing and removed CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. long build Set a long timeout for formula testing labels Aug 10, 2022
@carlocab
Copy link
Copy Markdown
Member Author

Still looking at backporting the 3.10 patch. Is this a suitable workaround in the meantime, @Bo98?

@carlocab
Copy link
Copy Markdown
Member Author

Merging to unblock a bunch of other PRs.

@carlocab carlocab merged commit 9c31185 into Homebrew:master Aug 10, 2022
@carlocab carlocab deleted the setuptools-workaround branch August 10, 2022 15:15
@Bo98
Copy link
Copy Markdown
Member

Bo98 commented Aug 10, 2022

Yeah seems fine as a temp fix.

@github-actions github-actions bot added the outdated PR was locked due to age label Sep 10, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CI-no-bottles Merge without publishing bottles CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. legacy Relates to a versioned @ formula outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants