gobject-introspection + dependents: migrate to python@3.10#107645
gobject-introspection + dependents: migrate to python@3.10#107645carlocab wants to merge 17 commits intoHomebrew:masterfrom
python@3.10#107645Conversation
6c40c73 to
ac35aee
Compare
|
|
|
|
|
Not sure about compatibility, but it would be good to update |
Formula/virt-manager.rb
Outdated
There was a problem hiding this comment.
Would be good to see if this works with our docutils.
There was a problem hiding this comment.
Is it a runtime dependency? There is a depends_on "docutils" => :build so definitely odd that both resource and dependency are in formula.
On side note, virt-manager should probably be updated to 4.1.0 to get virt-manager/virt-manager@90e1354
There was a problem hiding this comment.
From quick glance, I didn't see any python code using docutils. Setup runs command rst2man. May be okay to drop resource.
Formula/virt-manager.rb
Outdated
There was a problem hiding this comment.
Not sure where this dependency came from. I'm guessing it was from requests but it shouldn't have been added on Python 3: chardet>=3.0.2,<5; python_version < "3"'. As of 2.28.0, Python 2 support has been dropped.
Also missing charset-normalizer:
❯ pipgrip requests --tree
requests (2.28.1)
├── certifi>=2017.4.17 (2022.6.15)
├── charset-normalizer<3,>=2 (2.1.0)
├── idna<4,>=2.5 (3.3)
└── urllib3<1.27,>=1.21.1 (1.26.11)|
|
|
Dropped |
Also, explicitly specify `python3.10` for Homebrew#107517.
Also, explicitly specify `python3.10` for Homebrew#107517.
Also: - use our `libcython` instead of vendoring it. - explicitly specify `python3.10` for Homebrew#107517.
Attempting to rebuild `virt-manager` fails, so we're unable to migrate it to `python@3.10`.
| # This shouldn't be needed, but this fails to link with libpython3.10.so. | ||
| # TODO: Remove this when `python@3.10` is no longer keg-only. | ||
| ENV.append "LDFLAGS", "-Wl,-rpath,#{Formula["python@3.10"].opt_lib}" if OS.linux? |
There was a problem hiding this comment.
Seems odd. I wonder if there is a brew bug. I downloaded previous run's bottle and it is interesting that one library (lib/python3.10/site-packages/gi/overrides/_gi_gst.cpython-310-x86_64-linux-gnu.so) has python@3.10 in RPATH but the other (lib/gstreamer-1.0/libgstpython.so) doesn't.
The only difference between two RPATHS is @@HOMEBREW_PREFIX@@/opt/python@3.10/lib.
There was a problem hiding this comment.
Would help to be able to find the compiler/linker invocation when these objects are created, but Linux doesn't upload logs properly, unfortunately.
|
@yurikoles, do you mind taking a look at migrating |
|
Only Intel Big Sur left running. Should be done in the next hour or so. |
| libexec/Language::Python.site_packages(python3)/"zim/config/basedirs.py", | ||
| libexec/"vendor"/Language::Python.site_packages(python3)/"xdg/BaseDirectory.py", |
There was a problem hiding this comment.
| libexec/Language::Python.site_packages(python3)/"zim/config/basedirs.py", | |
| libexec/"vendor"/Language::Python.site_packages(python3)/"xdg/BaseDirectory.py", | |
| libexec/site_packages/"zim/config/basedirs.py", | |
| libexec/"vendor"/site_packages/"xdg/BaseDirectory.py", |
| depends_on "python@3.10" | ||
|
|
||
| uses_from_macos "flex" => :build | ||
| uses_from_macos "libffi", since: :catalina |
There was a problem hiding this comment.
We actually need glib to make the same declaration for this to work.
python@3.10python@3.10python@3.10python@3.10python@3.10python@3.10python@3.10python@3.10python@3.10python@3.10python@3.10python@3.10brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?