wxwidgets*, wxpython: migrate jpeg to jpeg-turbo#107066
wxwidgets*, wxpython: migrate jpeg to jpeg-turbo#107066cho-m wants to merge 3 commits intoHomebrew:masterfrom
jpeg to jpeg-turbo#107066Conversation
carlocab
left a comment
There was a problem hiding this comment.
Would also be nice to get wxpython to use our wxwidgets and link with the dependencies properly. But could be done separately.
May be possible with |
Huh; I thought wet used the vendored one since 3.0 didn't work. |
Haven't looked at previous discussions, but Fedora and Arch were able to build with 3.0. Arch now applies a couple patches to support 3.2. |
|
I also don’t mind following Arch’s patches for wxpython. |
|
The tedious part is there are 3 sets of patches:
I'm hoping upstream will do a 4.2.0 release "soon" which should fix all of these (https://github.com/wxWidgets/Phoenix/blob/master/CHANGES.rst#420-rumors-of-my-death-are-only-slightly-exaggerated). Otherwise, could explore in separate PR. |
| ENV.append_to_cflags "-I#{sdk}/usr/include" | ||
| end | ||
| system "python3", *Language::Python.setup_install_args(prefix) | ||
| system "python3.9", *Language::Python.setup_install_args(prefix) |
There was a problem hiding this comment.
| system "python3.9", *Language::Python.setup_install_args(prefix) | |
| system "python3.9", *Language::Python.setup_install_args(prefix, "python3.9") |
| if OS.mac? | ||
| sdk = MacOS.sdk_path_if_needed | ||
| ENV.append_to_cflags "-I#{sdk}/usr/include" if sdk | ||
| if OS.mac? && (sdk = MacOS.sdk_path_if_needed) |
There was a problem hiding this comment.
| if OS.mac? && (sdk = MacOS.sdk_path_if_needed) | |
| if (sdk = MacOS.sdk_path_if_needed) |
We don't need the OS.mac?. We might even be able to remove the parens.
carlocab
left a comment
There was a problem hiding this comment.
Can fix comments in a separate PR.
|
🤖 A scheduled task has triggered a merge. |
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?