Skip to content

pmdmini 2.0.0#106629

Closed
mistydemeo wants to merge 4 commits intoHomebrew:masterfrom
mistydemeo:pmdmini_2_0_0
Closed

pmdmini 2.0.0#106629
mistydemeo wants to merge 4 commits intoHomebrew:masterfrom
mistydemeo:pmdmini_2_0_0

Conversation

@mistydemeo
Copy link
Copy Markdown
Contributor

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@chenrui333 chenrui333 added build failure CI fails while building the software CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Aug 7, 2022
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Aug 31, 2022
@github-actions github-actions bot closed this Sep 7, 2022
@cho-m cho-m mentioned this pull request Sep 21, 2022
6 tasks
@cho-m cho-m reopened this Sep 22, 2022
@BrewTestBot BrewTestBot added the no Linux bottle Formula has no Linux bottle label Sep 23, 2022
@cho-m cho-m added build failure CI fails while building the software linux Linux is specifically affected and removed stale No recent activity build failure CI fails while building the software labels Sep 23, 2022
@cho-m
Copy link
Copy Markdown
Member

cho-m commented Sep 23, 2022

Looks like an #include <signal.h> might be missing

@danielnachun danielnachun removed build failure CI fails while building the software linux Linux is specifically affected labels Oct 4, 2022
@danielnachun
Copy link
Copy Markdown
Contributor

A missing #include <signal.h> and the -fpermissive CFLAG was all that was needed to fix this on Linux.

Copy link
Copy Markdown
Contributor

@danielnachun danielnachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I upstreamed the fixes here and added a link to the PR. We can merge this now.

@BrewTestBot
Copy link
Copy Markdown
Contributor

:shipit: @danielnachun has triggered a merge.

@mistydemeo mistydemeo deleted the pmdmini_2_0_0 branch October 4, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. no Linux bottle Formula has no Linux bottle

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants