Add a patch to improve libffi support for Apple Silicon#340
Add a patch to improve libffi support for Apple Silicon#340carlocab merged 1 commit intoHomebrew:masterfrom
Conversation
The PR adds a patch that brings in improvements from Apple's libffi (specifically libffi-26). These improvements are needed to use libffi with ghc. Commits: libffi/libffi@4c7bde3 libffi/libffi#565 I added additional configure logic to ensure that FFI_TRAMPOLINE_WHOLE_DYLIB is set on Apple Silicon (it is hard-coded to 1 in libffi-26 for aarch64). Signed-off-by: Nathan Hjelm <hjelmn@cs.unm.edu>
|
Patch looks big because it includes generated files (configure, Makefile.in, etc). |
|
Can we not use the upstream patches? |
|
Sure. I will have to create one myself for the configury changes. If that is the preferred way the formula will have to depend on autoconf for build and call autoreconf. |
|
If you need autoreconf to use the upstream patches then it may be cleaner to just use this one. That way when the patch is outdated it's more easily noticed that it's no longer needed. The autoconf dependency, on the other hand, could stick for a while, even when not necessary. |
|
Yeah. This patch includes a change to configure.ac to set |
|
What is the status on this? I want to update the formula but I am waiting on this to go in first. |
|
Thanks, @hjelmn! |
The PR adds a patch that brings in improvements from Apple's libffi
(specifically libffi-26). These improvements are needed to use libffi
with ghc.
Commits:
libffi/libffi@4c7bde3
libffi/libffi#565
I added additional configure logic to ensure that FFI_TRAMPOLINE_WHOLE_DYLIB
is set on Apple Silicon (it is hard-coded to 1 in libffi-26 for aarch64).
Signed-off-by: Nathan Hjelm hjelmn@cs.unm.edu