diagnostic: remove duplicate checks.#899
Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom Sep 9, 2016
MikeMcQuaid:diagnostic-duplicate-remove
Merged
diagnostic: remove duplicate checks.#899MikeMcQuaid merged 1 commit intoHomebrew:masterfrom MikeMcQuaid:diagnostic-duplicate-remove
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:diagnostic-duplicate-remove
Conversation
This was referenced Sep 9, 2016
Contributor
|
may have to disable that "Required" thing ... I guess something in test-bot is out of order so it's still using the old bits? |
Member
Author
|
@ilovezfs Nope, valid test failure 😀 |
Contributor
|
ah because you didn't update the tests that go with the diagnostic changes... I see |
Contributor
|
💚 |
Contributor
|
@MikeMcQuaid thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew testswith your changes locally?Remove duplicate checks added in #896.