Handle missing formulae in runtime_dependencies#4483
Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom Jul 16, 2018
MikeMcQuaid:runtime-dependencies-missing-formulae
Merged
Handle missing formulae in runtime_dependencies#4483MikeMcQuaid merged 1 commit intoHomebrew:masterfrom MikeMcQuaid:runtime-dependencies-missing-formulae
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:runtime-dependencies-missing-formulae
Conversation
Hopefully put this to bed for once and for all. Add a new method `runtime_formulae_dependencies` which returns the `runtime_dependencies` which have only the `Formula` objects that exist. I've checked all the `runtime_dependencies` callers and updated them accordingly. Also, fix a few cases where runtime dependencies were being read from the tab when this wasn't desirable.
ilovezfs
approved these changes
Jul 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully put this to bed for once and for all. Add a new method
runtime_formula_dependencieswhich returns theruntime_dependencieswhich have only theFormulaobjects that exist. I've checked all theruntime_dependenciescallers and updated them accordingly.Also, fix a few cases where runtime dependencies were being read from the tab when this wasn't desirable.
Fixes #4482.
brew stylewith your changes locally?brew testswith your changes locally?