Cleanup some more residual test-prof workarounds#21643
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes leftover test-prof-specific RuboCop loading workarounds now that the RuboCop plugin/bundler setup is expected to work without manual requires.
Changes:
- Drop the explicit
require "rubocop/test_prof"from the RuboCop wrapper entrypoint. - Simplify the RuboCop integration spec to run
rubocopwithout preloadingsorbet-runtime,extend/module, orrubocop/test_prof.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
Library/Homebrew/utils/rubocop.rb |
Removes manual rubocop/test_prof require so RuboCop plugin loading is solely config-driven. |
Library/Homebrew/test/rubocop_spec.rb |
Simplifies the spawned RuboCop invocation by removing preloads that were previously used as workarounds. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #21564
There are a few more residual
test-profreferences that are no longer needed now that their bundler setup is fixed.