cmd/update-report: handle cask-to-formula tap migration with rename#21642
Merged
MikeMcQuaid merged 1 commit intomainfrom Feb 28, 2026
Merged
cmd/update-report: handle cask-to-formula tap migration with rename#21642MikeMcQuaid merged 1 commit intomainfrom
MikeMcQuaid merged 1 commit intomainfrom
Conversation
0f231f7 to
7a5111a
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a bug in brew update-report’s tap-migration handling where a cask migrating from homebrew/cask to a formula in homebrew/core (with a rename) could be skipped or mishandled.
Changes:
- Adjust cask-migration detection to check the existing (old) Caskroom path rather than the new formula name.
- Install the migrated formula with
--skip-linkand then explicitlybrew link --overwritewhen appropriate.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MikeMcQuaid
approved these changes
Feb 28, 2026
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Looks good! Happy either this either option you mentioned. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?Fix a bug in tap migration from homebrew-cask to homebrew-core when combined with a rename.
Previously it skipped installing formula as looking for wrong name of Cask.
Changing name allowed installation to continue, but would fail to link at install time since Cask already owns symlink. Two options here:
--overwriteat install time--skip-linkand then let this be handled in existingbrew linkstep.Not sure if there is a specific reason we were doing latter so just used simpler
brew install --overwrite