Add generate-zap command to create zap stanzas#21633
Merged
Conversation
Signed-off-by: Patrick Linnane <patrick@linnane.io>
da58ccf to
8265b79
Compare
MikeMcQuaid
approved these changes
Feb 27, 2026
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Looks good! Much nicer than having this in Bash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?Claude Opus 4.6 created the initial implementation. I reworked it to conform to our existing code style, and verified the paths are real and correct. I also performed local testing with a few casks and had no issues.
For years we've recommended https://github.com/nrlquaker/homebrew-createzap as the way to create
zapstanzas for Homebrew/cask. While this external command has been wonderful, it's always bothered me that we had to point to something external for a required stanza. This PR adds a newgenerate-zapcommand, so we can createzapstanzas via our own official tooling.