upgrade,reinstall: make resilient to individual failures#21618
Merged
MikeMcQuaid merged 1 commit intoHomebrew:mainfrom Feb 24, 2026
Merged
Conversation
MikeMcQuaid
reviewed
Feb 24, 2026
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
@koddsson Thanks again! One note on tests.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
a16dec2 to
4d2c2c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uninstallresilience). Applies the same pattern tobrew upgradeandbrew reinstall: when some named arguments can't be resolved, the valid ones are still processed and unavailable names are reported viaofailat the end.upgrade, guards against empty resolved lists accidentally triggering the "upgrade all outdated" path when names were given but all failed resolution.Cask::Reinstall.reinstall_casks(matching the existing pattern inCask::Upgrade.upgrade_casks!andCask::Uninstall.uninstall_casks).Test plan
brew tests --only=cmd/upgrade— all passbrew tests --only=cmd/reinstall— all passbrew tests --only=cask/reinstall— all passbrew style --fix --changed— no offensesbrew upgrade valid_formula nonexistentupgrades the formula and exits non-zerobrew reinstall valid_formula nonexistentreinstalls the formula and exits non-zero🤖 Generated with Claude Code