linkage_cache_store: typed: strict#21594
Merged
MikeMcQuaid merged 4 commits intoHomebrew:mainfrom Feb 24, 2026
Merged
Conversation
f2fe850 to
e640fd0
Compare
Contributor
Author
|
The What's happening: The Verification: The merge ref ( Filed: Homebrew/actions#796 |
e640fd0 to
1a89ca4
Compare
MikeMcQuaid
reviewed
Feb 22, 2026
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Great work so far! One question then good to merge.
Add Sorbet `sig` annotations to all methods and `T.let` for instance variables to enable `typed: strict` in `linkage_cache_store.rb`. Contributes to Homebrew#17297 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The `CacheStore` base class used `*args` with `raise NotImplementedError` as a pseudo-abstract pattern. When subclasses add Sorbet `sig` annotations, the Sorbet runtime's override shape validation rejects the incompatible signatures (child methods have fixed params, parent has `*args`). Replace this pattern with Sorbet's proper `abstract!` declaration and remove the pseudo-abstract methods entirely. `CacheStore` is never instantiated directly - all callers use concrete subclasses. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Pass `path.to_s` instead of `path` (a Pathname) to `LinkageCacheStore.new`, matching the pattern used in `linkage_checker.rb`. The sig on `initialize` correctly requires a String since the value is used as a JSON-serializable database key. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
f0d6615 to
8be3734
Compare
MikeMcQuaid
approved these changes
Feb 24, 2026
Member
|
Thanks @costajohnt! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
linkage_cache_store.rbfromtyped: truetotyped: strictsigannotations to all 6 methods (initialize,keg_exists?,update!,fetch,delete!,fetch_hash_values)T.letfor@keg_pathinstance variable ininitializeCacheStoreproperly abstract (abstract!) and remove pseudo-abstract*argsmethods that usedraise NotImplementedError. This resolves the Sorbet runtime override shape validation that occurs when subclass methods have typed signatures with fixed parameters while the parent used*args.keg.rbwherePathnamewas passed toLinkageCacheStore.newinstead ofString(surfaced by the new sig annotation)Contributes to #17297
AI/LLM Disclosure
This PR was developed with assistance from Claude (Opus 4.6) via Claude Code. All code has been reviewed and understood. I can address review comments directly.
Test plan
brew typecheck— no errorsbrew style Library/Homebrew/cache_store.rb Library/Homebrew/linkage_cache_store.rb Library/Homebrew/keg.rb— no offensesbrew tests --only=linkage_cache_store— 7 examples, 0 failuresbrew tests --only=cache_store— 11 examples, 0 failuresbrew tests --only=description_cache_store— 7 examples, 0 failuresbrew tests --only=keg— 33 examples, 0 failuresHOMEBREW_SORBET_RUNTIME=1(simulating CI environment)