Skip to content

utils/pypi: skip excluded packages message when empty #21384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
p-linnane merged 1 commit into from
Jan 11, 2026
Merged

utils/pypi: skip excluded packages message when empty #21384

p-linnane merged 1 commit into from
Jan 11, 2026
+4 −2

Conversation

@p-linnane
Copy link
Member

@p-linnane p-linnane commented Jan 10, 2026

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

I noticed while creating a new formula that we're printing an empty line here:

Before:

==> Retrieving PyPI dependencies for "https://github.com/<foo>/v0.4.0.tar.gz"...
==> Retrieving PyPI dependencies for excluded ""...
==> Getting PyPI info for "aiohappyeyeballs==2.6.1"

After:

==> Retrieving PyPI dependencies for "https://github.com/<foo>/v0.4.0.tar.gz"...
==> Getting PyPI info for "aiohappyeyeballs==2.6.1"

Copilot AI review requested due to automatic review settings January 10, 2026 23:36
Copilot AI reviewed Jan 10, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes an issue where an empty message was being printed when there are no excluded packages during PyPI dependency retrieval for Python formulas.

Changes:

  • Added a conditional check to skip printing the excluded packages message and making the pip_report call when the exclude_packages array is empty

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@p-linnane p-linnane added this pull request to the merge queue Jan 11, 2026
Merged via the queue into main with commit 1c34eff Jan 11, 2026
61 of 63 checks passed
@p-linnane p-linnane deleted the pypi-silence-excluded-message branch January 11, 2026 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@daeho-ro daeho-ro daeho-ro approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@p-linnane @daeho-ro