cask/audit: check pkg for minimum supported os version
#21375
Merged
+21
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27959a4 to
aa2cb14
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds functionality to check pkg artifacts for minimum supported macOS versions by examining their Distribution files. Previously, pkg artifacts without Info.plist files were not checked for minimum OS version requirements.
Key Changes:
- Adds pkg expansion and Distribution file parsing to extract os-version min attribute
- Implements cleanup of temporary directories using ensure blocks
- Skips Info.plist checking for pkg artifacts after Distribution file check
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aa2cb14 to
6fdf6bf
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
6fdf6bf to
dc32cf4
Compare
8 tasks
MikeMcQuaid
approved these changes
Jan 9, 2026
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Thanks! Small style comment but happy to ship when it's working for you.
dc32cf4 to
db86073
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?When a
pkgdoes not contain aninfo.plistfile we are currently not checking for a minimum supported os version.The
pkginstaller itself can have a minimum specified in its distribution, so check it.I am not sure how we want to preference this, as we we may want it to only take effect if the existing method doesn't find anything. At the moment it utilises the new check first.