Add --no-exit-code to generate-man-completions
#21361
Merged
+17
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9b852a1 to
875eaa3
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a --no-exit-code flag to the generate-man-completions command to prevent it from exiting with a non-zero exit code when no changes are detected. This fixes an issue in CI where the wrong command (regenerate-man-pages) was being called with || true to suppress failures.
Key changes:
- Added
--no-exit-codeswitch to make the command always exit with code 0 - Refactored exit code logic to conditionally call
ofailbased on the flag - Updated the docs workflow to use the correct command with the new flag
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
Library/Homebrew/dev-cmd/generate-man-completions.rb |
Added --no-exit-code switch and refactored exit code logic to honor the flag |
Library/Homebrew/sorbet/rbi/dsl/homebrew/dev_cmd/generate_man_completions.rbi |
Added Sorbet type signature for the new no_exit_code? method |
.github/workflows/docs.yml |
Updated to use brew generate-man-completions --no-exit-code instead of the non-existent brew regenerate-man-pages || true |
Files not reviewed (1)
- Library/Homebrew/sorbet/rbi/dsl/homebrew/dev_cmd/generate_man_completions.rbi: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MikeMcQuaid
reviewed
Jan 5, 2026
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Whoops, my typo/code completion fail here! Thanks for fix.
MikeMcQuaid
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that we are calling
brew regenerate-man-pages || truein CI, but this always fails becauseregenerate-man-pagesisn't actually a command.Instead, let's add a
--no-exit-codeoption togenerate-man-completionsthat will change the exit code behaviour to always be0. Then, we can use this in the workflow to remove the|| trueand fail if the command itself actually fails.