Use #present? instead of #empty? to check presence in CaskStruct
#21349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves nil-safety in the CaskStruct API code by replacing a negated empty? check with present?, making it consistent with the surrounding code and safer when dealing with potentially nil values.
- Changes one line to use
present?instead of!empty?for checkingdepends_on_argspresence - Ensures consistency with all other predicate assignments in the same code block
- Adds nil-safety protection in case
hash["depends_on_args"]is unexpectedlynil
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
p-linnane
approved these changes
Jan 2, 2026
Member
|
Thanks @Rylan12! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21348
Let's use
#present?instead of negating#empty?to in case we call these onnil.[].present?and{}.present?returnfalse, which gives us the same result.