Ignore missing items when generating CaskStruct
#21343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses an issue where uninstalling casks that have saved JSON data in an older format could fail due to missing keys. The changes add safe navigation operators (&.) to prevent NoMethodError exceptions when certain fields are absent from the stored JSON data.
Key Changes:
- Added safe navigation operators to handle potentially missing JSON keys in the cask struct generation
- Applied defensive programming to
container,depends_on,rename, andurl_specsfields
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
f09c404 to
2a98739
Compare
p-linnane
approved these changes
Dec 31, 2025
This was referenced Dec 31, 2025
Member
|
Thanks @Rylan12! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21342
Follow-up to #21333
If we are uninstalling a cask that had saved its JSON data instead of its ruby source, there is a chance that this data is an older format and it may be missing certain keys. In all places that are applicable, let's use safe-navigation operators to fall-back to default values if needed.