Document that not supporting macOS versions can get a cask rejected #21336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a note regarding casks that do not work for modern macOS versions, specifically mentioning the impact of Apple's dropping support for Rosetta.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds documentation about rejecting casks that don't support modern macOS versions, with specific mention of the future discontinuation of Rosetta support in macOS 28.
- Documents rejection criteria for casks incompatible with modern macOS versions
- References future plans regarding Rosetta support and x86-only software
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MikeMcQuaid
approved these changes
Dec 29, 2025
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Looks good with wording tweak.
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
p-linnane
approved these changes
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a note regarding casks that do not work for modern macOS versions, specifically mentioning the impact of Apple's dropping support for Rosetta.
brew lgtm(style, typechecking and tests) with your changes locally?Not sure if this is the best place to document this, but I think it's good to have a note about the support for Rosetta.