Add String#to_string_or_symbol extension
#21332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extracts string-to-symbol conversion functionality from the Formulary module into a reusable String extension method called to_string_or_symbol. This makes the functionality available for casks and other parts of the codebase where strings prefixed with : need to be converted to symbols.
Key changes:
- Added
String#to_string_or_symbolmethod that converts strings starting with:to symbols, otherwise returns the string unchanged - Migrated test coverage from
formulary_spec.rbto newstring_spec.rb - Updated all usages in
api/formula.rbto use the new String extension method
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
Library/Homebrew/extend/string.rb |
Adds the new to_string_or_symbol method to the String class with proper documentation and type signatures |
Library/Homebrew/test/extend/string_spec.rb |
New test file providing coverage for the to_string_or_symbol method |
Library/Homebrew/formulary.rb |
Removes the now-extracted convert_to_string_or_symbol class method |
Library/Homebrew/test/formulary_spec.rb |
Removes tests for the deleted convert_to_string_or_symbol method |
Library/Homebrew/api/formula.rb |
Updates two call sites to use the new instance method instead of the removed class method |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MikeMcQuaid
reviewed
Dec 29, 2025
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Makes sense to extract but to Utils please 🙇🏻
e9a5b81 to
bb6951f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is a method in
Formularyto convert strings to symbols if they begin with:. This functionality isn't specific to formulae, so extracting this out lets it be used in casks and other places where it might be useful.I opted for patching
Stringto define this method since it's not overriding an existing method and seems potentially useful for any string, but I'm sure there's another place this can go if preferred to avoid the monkey patch.