Add deprecate_args and disable_args to cask API
#21331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds deprecate_args and disable_args fields to the cask DSL and JSON API to capture the original arguments passed to deprecate! and disable! methods. This enables accurate reconstruction of these method calls in a follow-up PR, preserving the as-written deprecation/disabling status rather than the computed status at JSON generation time.
Key Changes:
- Added
deprecate_argsanddisable_argsinstance variables to store method arguments as hashes - Included proper type annotations for the new fields
- Updated JSON test fixtures to reflect the new API structure
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Library/Homebrew/cask/dsl.rb | Added deprecate_args and disable_args to DSL_METHODS, attr_readers, initialization, and set them within the deprecate! and disable! methods to capture the original arguments |
| Library/Homebrew/sorbet/rbi/dsl/cask/cask.rbi | Added Sorbet type signatures for the new deprecate_args and disable_args methods |
| Library/Homebrew/test/support/fixtures/cask/everything.json | Added deprecate_args and disable_args fields with null values to the test fixture |
| Library/Homebrew/test/support/fixtures/cask/everything-with-variations.json | Added deprecate_args and disable_args fields with null values to the variations test fixture |
Files not reviewed (1)
- Library/Homebrew/sorbet/rbi/dsl/cask/cask.rbi: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
146fe4c to
5da8d72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
deprecate_argsanddisable_argsfields to the cask JSON API to reflect the as-written deprecation/disabling status of each cask. This will be used in a follow-up PR to accurately calldeprecate!anddisable!in casks based on what was actually called in the cask's ruby file rather than the status at JSON generation time.