unpack_strategy: replace T.untyped, narrow types #21326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves type safety in the UnpackStrategy module and related code by replacing T.untyped with more specific types and narrowing return type signatures. This increases static type checking coverage and makes the code more maintainable.
Key changes:
- Changed
strategiesreturn type fromT.nilable(T::Array[UnpackStrategyType])toT::Array[UnpackStrategyType]since it's never nil - Replaced
T.untypedreturn types with more specific types (UnpackStrategy,void) - Replaced
map.compactpattern withfilter_mapand explicit type guard for better type safety
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Library/Homebrew/unpack_strategy.rb | Narrowed return types for strategies, detect, extract_nestedly, and each_directory methods; removed unnecessary safe navigation operators on strategies since it's now non-nilable |
| Library/Homebrew/cask/audit.rb | Replaced map with filter_map and added explicit Formula type check for better type safety when filtering dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?Narrowing some types to be more accurate. This includes replace T.untyped so static type checking coverage increases.