cask/artifacts: remove installer from macOS-only stanzas
#21320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed for `gcloud-cli` cask `installer` may be either a `:script` or `:manual`. There is nothing that block supporting installer scripts on Linux. Manual installation may be a problem, it might be worth check for `install :manual` usage or change the output message Signed-off-by: botantony <antonsm21@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables the installer artifact to be used in casks that run on Linux, needed specifically for the gcloud-cli cask. The change removes the installer artifact from the macOS-only restrictions since installer scripts (using :script) can run on Linux systems.
- Removes
::Cask::Artifact::Installerfrom theMACOS_ONLY_ARTIFACTSarray - Allows casks with installer artifacts to indicate Linux support via
supports_linux? - Prevents installation errors on Linux for casks using installer scripts
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
I think that should probably be done in this PR? |
Signed-off-by: botantony <antonsm21@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?Needed for
gcloud-clicaskinstallermay be either a:scriptor:manual. There is nothing that block supporting installer scripts on Linux. Manual installation may be a problem, it might be worth check forinstall :manualusage or change the output message