workflows/tests: run brew style on both official taps in one step #21319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Linnane <patrick@linnane.io>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR combines two separate brew style workflow steps that check Homebrew/core and Homebrew/cask into a single unified step. This optimization ensures that style violations in both official taps are reported together in a single workflow run, rather than potentially requiring multiple re-runs when issues exist in both taps.
- Merged two sequential
brew stylecommands into one step - Updated step name to reflect checking "official taps" (plural)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MikeMcQuaid
approved these changes
Dec 24, 2025
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
As long as this is definitely now checking both: 👍🏻
Member
Author
|
I used it to identify formulae and casks in #21316, so can confirm it works as intended. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?Rather than running brew style on Homebrew/core and Homebrew/cask in separate workflow steps, this PR combines them into a single step.
When run separately, the job often fails on issues in Homebrew/core, which are fixed, only for reruns to surface similar issues in Homebrew/cask. Because the first failure stops the job, we don’t get a complete view of style issues across both taps in one run.
Unifying the checks allows all style violations to be reported at once and addressed together.