test/formula_auditor_spec: add tests for dependency tag #21314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive test coverage for dependency tag validation in the formula auditor and fixes an incorrect type signature for the option_defined? method that was discovered while writing the tests.
- Adds tests for all dependency tag scenarios (valid tags, no-op tags, invalid tags, and option-based tags)
- Fixes type signature for
option_defined?to accept bothOptionandStringtypes
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Library/Homebrew/test/formula_auditor_spec.rb | Adds comprehensive test suite for dependency tag validation, covering valid tags (:build, :optional), no-op tags (:run, :linked), invalid tags, and option-based dependencies |
| Library/Homebrew/software_spec.rb | Corrects type signature of option_defined? from String to T.any(Option, String) to match actual usage where Option objects are passed |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MikeMcQuaid
approved these changes
Dec 24, 2025
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Thanks again, good catch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?Following up on lack of tests mentioned by Copilot in:
This found an incorrect type for
option_defined?as we pass in Option at:brew/Library/Homebrew/formula_auditor.rb
Line 331 in 57817e8