formula_auditor: check for valid dependency tags #21313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances formula auditing by adding validation for dependency tags to catch typos and invalid tag usage. The change extends the existing check for the deprecated :run tag to also check for :linked (another no-op tag) and validates that symbol tags are from the reserved set of valid tags.
- Replaces single-line check for
:runtag with a loop that validates all tags - Adds validation for
:linkedtag (documented as a no-op) - Adds validation to flag non-reserved symbol tags as invalid
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MikeMcQuaid
approved these changes
Dec 23, 2025
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
This is great, thanks again @cho-m!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?Changes:
:no_linkageusage homebrew-core#259811:linkedwhich is mentioned to be a no-op:brew/Library/Homebrew/dependable.rb
Line 10 in 1107c99
Not aware of any situation of a non-reserved Symbol (based on Homebrew/core), but can update this to be core-only if there is a valid use case for 3rd party taps.