bundle/installer: fix fetching untapped packages. #21312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where brew bundle was attempting to fetch formulae from taps that weren't installed yet, causing the fetch operation to fail. The fix adds a check to skip fetching formulae/casks from taps that haven't been installed yet, allowing the tap to be installed first before attempting to fetch its packages.
Key Changes
- Added
tap_installed?helper method to check if a package's tap is currently installed - Modified
fetchable_formulae_and_casksto skip packages from uninstalled taps - Added comprehensive test coverage for the new behavior
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Library/Homebrew/bundle/installer.rb | Implements the tap_installed? helper method and adds checks to skip fetching packages from uninstalled taps |
| Library/Homebrew/test/bundle/installer_spec.rb | Adds test for skipping fetch of untapped formulae and updates test setup to mock TapInstaller.installed_taps |
| Library/Homebrew/test/bundle/commands/install_spec.rb | Updates test setup to mock TapInstaller.installed_taps for consistency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ZhongRuoyu
approved these changes
Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21311