extend/os/mac/system_config: show Metal Toolchain version #21309
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enhances the Metal Toolchain detection to display version information instead of just reporting "present". The change extracts version details from the Metal toolchain path and formats them in a user-friendly way.
- Changed from running
metal -vto usingxcrun --find metalto get the toolchain path - Added regex parsing to extract version components from the MetalToolchain path format
- Implemented version formatting with character arithmetic to convert numeric letter representations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Is this accurate on x86_64? The paths are totally different so parsing the path isn't necessarily stable. |
|
|
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Thanks looks good so far!
Signed-off-by: Patrick Linnane <patrick@linnane.io>
bbd2e4a to
c94a2b3
Compare
|
Reworked this a bit and should be much easier to read. @Bo98 I opted to just return early on Intel given support is winding down. |
brew lgtm(style, typechecking and tests) with your changes locally?Follow up to #21117. This matches how Apple derives the Metal toolchain version, since there is no literal build identifier on disk.