options: typed: strict
#21307
Merged
options: typed: strict
#21307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds Sorbet typed: strict mode to the options.rb file as part of the broader initiative (#17297) to enforce strict typing across all non-package files in the Homebrew organization. The changes add comprehensive type signatures to all methods and classes in the file to satisfy Sorbet's strict mode requirements.
- Upgraded from
typed: truetotyped: strict - Added type signatures to all methods in
Option,DeprecatedOption, andOptionsclasses - Added explicit type annotations using
T.letfor some instance variables and modified comparison operators to handle type checking
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Symbols were used for predefined options, which are no longer supported.
Member
Author
|
Failure is typo in some formulae |
MikeMcQuaid
approved these changes
Dec 23, 2025
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Looks good thanks again @cho-m!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?Part of #17297