cask/metadata: typed: strict
#21305
Merged
cask/metadata: typed: strict
#21305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR upgrades the Sorbet type checking level from typed: true to typed: strict for the cask/metadata.rb file, as part of the broader effort tracked in issue #17297. The upgrade requires adding explicit type signatures to all methods and making minor refactorings to satisfy strict type checking requirements.
Key changes:
- Added Sorbet type signatures to all public and private methods in the Metadata module
- Refactored
metadata_timestamped_pathto use a case statement for clearer control flow - Added defensive programming to reject invalid timestamp symbols
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Library/Homebrew/cask/metadata.rb | Upgraded from typed: true to typed: strict; added type signatures to all methods; refactored metadata_timestamped_path to use case statement with defensive symbol validation |
| Library/Homebrew/cask/cask.rb | Modified timestamped_versions to explicitly convert Pathname to string before passing to Pathname.glob, likely to satisfy strict type checking requirements |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?Part of #17297