bundle/*installer: typed: strict
#21300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds strict typing (typed: strict) to multiple bundle installer files and related modules, enabling Sorbet's strictest type checking. The changes add type signatures to all public methods and properly annotate instance variables with T.let to satisfy strict typing requirements.
Key changes:
- Upgraded typing level from
typed: truetotyped: strictacross 7 bundle installer files - Added comprehensive method signatures with parameter and return types
- Annotated memoized instance variables with
T.letfor proper type inference
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| bundle/vscode_extension_installer.rb | Added strict typing with method signatures and T.let for @installed_extensions |
| bundle/tap_installer.rb | Added strict typing, extracted clone_target parameter explicitly, added signatures |
| bundle/remover.rb | Added strict typing with proper type annotations and explicit empty array return |
| bundle/mac_app_store_installer.rb | Added strict typing with method signatures and T.let for instance variables |
| bundle/installer.rb | Added strict typing with comprehensive signature for install! method |
| bundle/go_installer.rb | Added strict typing with method signatures and T.let for @installed_packages |
| bundle/commands/remove.rb | Updated signature to use String instead of T.anything for args |
| bundle/cargo_installer.rb | Added strict typing with method signatures and T.let for @installed_packages |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
b004a01 to
dfff0d0
Compare
dfff0d0 to
1745486
Compare
1745486 to
179e09d
Compare
MikeMcQuaid
approved these changes
Dec 22, 2025
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Great work again, thanks for chugging through these @cho-m!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?Part of #17297
Adds strict typing for: