bundle: replace pluralize_dependency with Utils.pluralize
#21299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR replaces a custom pluralize_dependency helper method in the Bundle DSL with the existing Utils.pluralize utility method, reducing code duplication and aligning with Homebrew's standard utilities.
- Removes the custom
pluralize_dependencymethod fromBundle::Dsl - Updates
Bundle::Installerto useUtils.pluralizeinstead - Removes associated tests for the deprecated method
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Library/Homebrew/bundle/dsl.rb | Removes the custom pluralize_dependency method that is being replaced with Utils.pluralize |
| Library/Homebrew/bundle/installer.rb | Updates two usages of Homebrew::Bundle::Dsl.pluralize_dependency to use Utils.pluralize with appropriate parameters |
| Library/Homebrew/test/bundle/dsl_spec.rb | Removes tests for the deprecated pluralize_dependency method (functionality is already tested in test/utils_spec.rb) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?May have been needed when Homebrew/bundle was separate repo but should just share the same code as rest of brew now.