Replace T.cast to Bottle with flow-sensitivity #21298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors type assertions in the download/fetch code to use Sorbet's flow-sensitivity instead of explicit T.cast calls. By combining the check_attestation condition with an is_a?(Bottle) type guard, Sorbet can automatically narrow the type without requiring manual type assertions.
Key changes:
- Replaced
T.cast(downloadable_object, Bottle)with runtime type checking usingis_a?(Bottle) - Combined the attestation check condition with the type guard for cleaner code
- Removed intermediate
bottlevariable assignments, passingdownloadable_objectordownloadabledirectly
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Library/Homebrew/formula_installer.rb | Refactored attestation check to use flow-sensitive type narrowing instead of T.cast |
| Library/Homebrew/download_queue.rb | Refactored attestation check in download queue to use flow-sensitive type narrowing instead of T.cast |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MikeMcQuaid
approved these changes
Dec 22, 2025
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Oh nice, TIL, thanks @cho-m!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?This allows Sorbet to track the types rather than needing an extra type assertion.
T.castis not statically checked (likeT.must) so usually better to avoid wherever possible - https://sorbet.org/docs/type-assertions#static-vs-runtime-checking