Add test for installed cask dependency status #21294
Merged
+64
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please provide a better issue/pull request title and/or description! |
1d32d8a to
3c623fe
Compare
MikeMcQuaid
reviewed
Dec 21, 2025
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Can this get rebased? the git diff shows a bunch of the original merged changes.
3c623fe to
7950b57
Compare
Contributor
Author
|
@MikeMcQuaid I think something is wrong with master/main becuase I don't see my previous changes there: https://github.com/Homebrew/brew/blob/main/Library/Homebrew/test/cask/info_spec.rb |
3c623fe to
e1b9faa
Compare
Member
|
@HaraldNordgren Ah, it's because your old PR was against |
MikeMcQuaid
reviewed
Dec 22, 2025
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Needs some test fixes it seems.
a4b1cfa to
73ea147
Compare
73ea147 to
b893e13
Compare
MikeMcQuaid
approved these changes
Dec 22, 2025
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Looks good, thanks again!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #17982, adding better tests.