patch: typed: strict
#21289
Merged
patch: typed: strict
#21289
+43
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR upgrades the type strictness level from typed: true to typed: strict for the Library/Homebrew/patch.rb file as part of the gradual migration to stricter typing (#17297). The changes add comprehensive Sorbet type signatures throughout the file and remove tests that are no longer applicable due to the type system enforcing constraints that were previously tested manually.
- Added Sorbet type signatures to all methods and instance variables
- Marked
EmbeddedPatchas abstract with proper abstract method declarations - Removed error handling for invalid input types that the type system now prevents
- Removed tests for error cases that are now type-level guarantees and for the abstract
EmbeddedPatchclass that can no longer be instantiated directly
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Library/Homebrew/patch.rb | Upgraded from typed: true to typed: strict, added comprehensive type signatures for methods and instance variables, marked EmbeddedPatch as abstract, and removed runtime error handling for type-level constraints |
| Library/Homebrew/test/patch_spec.rb | Removed tests for runtime type validation errors (now prevented by type system) and removed tests for abstract EmbeddedPatch class instantiation (no longer possible) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
494eead to
e6e65f3
Compare
MikeMcQuaid
reviewed
Dec 22, 2025
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Looks good so far, thanks!
MikeMcQuaid
reviewed
Dec 28, 2025
e6e65f3 to
4616a53
Compare
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
206f45d to
3c1e992
Compare
MikeMcQuaid
reviewed
Jan 7, 2026
d986076 to
b2f767c
Compare
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com> Signed-off-by: botantony <antonsm21@gmail.com>
b2f767c to
e0d9334
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?Part of #17297