Skip to content

Conversation

@p-linnane
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

Bootsnap 1.19.0 removed CompileCache::JSON. Removing this fixes Bootsnap.setup 'compile_cache_json' argument is deprecated and has no effect.

brew vendor-gems needed an additional require to handle Error: uninitialized constant Homebrew::DevCmd::VendorGems::GitHub.

Signed-off-by: Patrick Linnane <patrick@linnane.io>
Copilot AI review requested due to automatic review settings December 17, 2025 04:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Homebrew's portable Ruby from version 3.4.7 to 3.4.8 and fixes two related issues: removing a deprecated Bootsnap configuration option and adding a missing require statement. The Ruby version update is reflected consistently across all configuration files and portable Ruby distributions for all supported platforms.

Key Changes

  • Updates portable Ruby from 3.4.7 to 3.4.8 across all platforms (x86_64/arm64 for Linux/Darwin)
  • Removes deprecated compile_cache_json parameter from Bootsnap configuration
  • Adds missing require "utils/github" to vendor-gems.rb to fix uninitialized constant error

Reviewed changes

Copilot reviewed 3 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Library/Homebrew/vendor/portable-ruby-version Updates portable Ruby version from 3.4.7 to 3.4.8
Library/Homebrew/vendor/portable-ruby-x86_64-linux Updates SHA hash for x86_64 Linux portable Ruby distribution
Library/Homebrew/vendor/portable-ruby-x86_64-darwin Updates SHA hash for x86_64 Darwin portable Ruby distribution
Library/Homebrew/vendor/portable-ruby-arm64-linux Updates SHA hash for arm64 Linux portable Ruby distribution
Library/Homebrew/vendor/portable-ruby-arm64-darwin Updates SHA hash for arm64 Darwin portable Ruby distribution
Library/Homebrew/.ruby-version Updates Ruby version from 3.4.7 to 3.4.8
Library/Homebrew/Gemfile.lock Updates Ruby version from 3.4.7p58 to 3.4.8p72
Library/Homebrew/startup/bootsnap.rb Removes deprecated compile_cache_json option from Bootsnap.setup call
Library/Homebrew/dev-cmd/vendor-gems.rb Adds missing require for utils/github to fix GitHub constant error

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@p-linnane
Copy link
Member Author

Just need to wait for a new version of setup-ruby.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @p-linnane! Good to merge when 🟢

Signed-off-by: Patrick Linnane <patrick@linnane.io>
@p-linnane p-linnane enabled auto-merge December 17, 2025 16:14
@p-linnane p-linnane added this pull request to the merge queue Dec 17, 2025
Merged via the queue into main with commit 8e96d6f Dec 17, 2025
38 checks passed
@p-linnane p-linnane deleted the portable-ruby-3.4.8 branch December 17, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants