keg: typed: strict
#21259
Merged
keg: typed: strict
#21259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the keg.rb and related files to Sorbet's typed: strict mode by adding comprehensive type signatures and making necessary adjustments for type safety. This is part of a broader effort (#17297) to improve type checking across the Homebrew codebase.
Key Changes
- Upgraded from
typed: truetotyped: strictinkeg.rbandextend/os/mac/keg.rb - Added Sorbet type signatures (
sig) to all methods in the Keg class and related classes - Enhanced type safety by adding explicit type annotations to instance variables and memoized class variables using
T.let
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Library/Homebrew/keg.rb | Upgraded to typed: strict and added comprehensive type signatures to all methods, error classes, and instance variables |
| Library/Homebrew/keg_relocate.rb | Converted Pathname argument to String for codesign_patched_binary call to match type signature |
| Library/Homebrew/extend/os/mac/keg.rb | Upgraded to typed: strict and added type signatures to ClassMethods and instance methods |
| Library/Homebrew/extend/os/mac/keg_relocate.rb | Converted Pathname arguments to String for codesign_patched_binary calls to match type signature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?Part of
typed: strictin all (non-package) files in Homebrew organisation #17297