Add Cargo support to brew bundle
#21250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c79b83d to
9a2c62b
Compare
9a2c62b to
1c96b73
Compare
carlocab
approved these changes
Dec 16, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds support for Rust's Cargo package manager to brew bundle, enabling users to declare and manage Cargo packages in their Brewfiles. The implementation follows the existing pattern established by Go package support, providing feature parity for listing, dumping, installing, and checking Cargo packages.
Key Changes:
- Added
cargoDSL method to Brewfile syntax for declaring Cargo packages - Implemented installer, dumper, and checker modules for Cargo packages that automatically install Rust when needed
- Extended all
brew bundlesubcommands (dump, list, install, add, remove) to support Cargo packages with corresponding--cargoand--no-cargoflags
Reviewed changes
Copilot reviewed 24 out of 25 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| manpages/brew.1 | Updated manpage to document Cargo support in bundle description and new --cargo/--no-cargo flags |
| docs/Manpage.md | Updated documentation to describe Cargo package support and associated flags |
| docs/Brew-Bundle-and-Brewfile.md | Added Cargo example to Brewfile types documentation showing ripgrep installation |
| completions/zsh/_brew | Added --cargo and --no-cargo completions with proper mutual exclusions |
| completions/fish/brew.fish | Added --cargo and --no-cargo flag completions for Fish shell |
| completions/bash/brew | Added --cargo and --no-cargo flag completions for Bash shell |
| Library/Homebrew/cmd/bundle.rb | Added --cargo and --no-cargo switches, integrated Cargo into all bundle subcommands |
| Library/Homebrew/bundle.rb | Added which_cargo and cargo_installed? helper methods to main Bundle module |
| Library/Homebrew/bundle/cargo_installer.rb | New installer module that installs Rust if needed and manages Cargo package installations |
| Library/Homebrew/bundle/cargo_dumper.rb | New dumper module that lists installed Cargo packages from cargo install --list |
| Library/Homebrew/bundle/cargo_checker.rb | New checker module to verify Cargo package installation status |
| Library/Homebrew/bundle/dsl.rb | Added cargo() DSL method for Brewfile syntax |
| Library/Homebrew/bundle/lister.rb | Extended to support listing Cargo entries from Brewfiles |
| Library/Homebrew/bundle/installer.rb | Integrated CargoInstaller into package installation flow |
| Library/Homebrew/bundle/dumper.rb | Integrated CargoDumper into Brewfile generation |
| Library/Homebrew/bundle/checker.rb | Added cargo_packages_to_install check method |
| Library/Homebrew/bundle/commands/*.rb | Updated dump and list commands to accept cargo parameter |
| Library/Homebrew/sorbet/rbi/dsl/homebrew/cmd/bundle.rbi | Auto-generated Sorbet signatures for new cargo? and no_cargo? methods |
| Library/Homebrew/test/bundle/*_spec.rb | Comprehensive test coverage for all Cargo functionality including installer, dumper, checker, DSL, and command integration |
Files not reviewed (1)
- Library/Homebrew/sorbet/rbi/dsl/homebrew/cmd/bundle.rbi: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the Go support, this adds support for Rust's Cargo packages to
brew bundle.Fixes #21194