pypi: keep extra packages even if they are dependencies of exclude packages #21243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daeho-ro
commented
Dec 15, 2025
Member
Author
daeho-ro
left a comment
There was a problem hiding this comment.
One example is here, https://github.com/Homebrew/homebrew-core/blob/main/Formula/s/streamrip.rb.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the PyPI resource management logic where packages explicitly listed in extra_packages were being excluded if they appeared as dependencies of packages in exclude_packages. The fix ensures that extra_packages always take precedence by filtering them out from the resolved exclude_packages list after dependency resolution.
Key Changes:
- Added a second filter to remove
extra_packagesfromexclude_packagesafter the dependency tree of excluded packages is resolved
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MikeMcQuaid
approved these changes
Dec 15, 2025
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Makes sense to me, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?When a package is added to
exclude_packages, all of its dependencies are also excluded from the resource list. However, some of these dependencies may overlap with the target package's dependencies and need to be preserved.Previously, there was no way to keep these overlapping dependencies, they would be excluded even if explicitly listed in
extra_packages.This change ensures that packages explicitly specified in
extra_packagesare preserved, even when they appear in the dependency tree of excluded packages.