Skip to content

Conversation

@cho-m
Copy link
Member

@cho-m cho-m commented Dec 14, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

We always output recursive test dependencies when running brew deps --include-test --tree or --graph so the description is incorrect in those cases.

Copilot AI review requested due to automatic review settings December 14, 2025 19:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR clarifies the documentation for the --include-test flag in the brew deps command. The flag's behavior differs depending on whether it's used with --tree or --graph options: test dependencies are non-recursive by default but become recursive when used with these visualization modes.

  • Updates the description to accurately reflect that --include-test is non-recursive by default but becomes recursive when combined with --tree or --graph

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Dec 15, 2025
Merged via the queue into main with commit ffe11db Dec 15, 2025
43 checks passed
@MikeMcQuaid MikeMcQuaid deleted the deps-clarify-test branch December 15, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants