Add Homebrew's ruby to PATH for VSCode Ruby LSP setup
#21233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the VSCode Ruby LSP setup by ensuring Homebrew's ruby is available in PATH. After PR #21111, the setup-ruby-path function in ruby.sh no longer adds Homebrew's ruby binary directory to PATH (it only exports HOMEBREW_RUBY_PATH). Since VSCode sources the ruby-lsp-activate.sh script to set up its environment, the Ruby LSP needs the ruby and bundler executables to be findable in PATH. This PR resolves the issue by explicitly adding Homebrew's ruby bin directory to PATH after running the setup functions.
Key changes:
- Add Homebrew's ruby bin directory to PATH by computing it from
HOMEBREW_RUBY_PATH - Improve documentation with comments explaining zsh compatibility
- Enhance shellcheck directives for better static analysis
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cho-m
reviewed
Dec 13, 2025
cho-m
approved these changes
Dec 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #21111, Homebrew's ruby was no longer added to the PATH in the
ruby-lsp-setup.shfile. This meant that all subsequent setup steps were using the wrong Ruby, leading to the wrong Gem setup being used. This PR adds ruby back to the PATH to (mostly) fix vscode.Unfortunately, the
test-profissues (see #21220) are preventing RuboCop from working out of the box, so vscode is still slightly broken. The workaround is to comment out thetest-profplugin in.rubocop.ymltemporarily. That shouldn't be necessary once the next version oftest-profis released and gets merged in.