Skip to content

Conversation

@shfc
Copy link
Contributor

@shfc shfc commented Dec 13, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

What & Why

This PR fixes a bug where the download verification phase never transitions to "Verified" status after successful checksum verification. Currently, users see the status stuck at "Verifying" even after verification completes successfully, making it unclear whether the process finished successfully.

User-visible impact: Download progress now properly shows the complete flow:

Downloading → Downloaded → Verifying → Verified 

Changes

Added verifying! and verified! phase methods (matching existing downloading!, downloaded!, extracting! pattern) and updated verify_download_integrity() to call verified! when verification actually succeeds

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks @shfc!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Dec 13, 2025
Merged via the queue into Homebrew:main with commit a8ca776 Dec 13, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants