cask/{tab,pkg,staged,utils}: typed: strict
#21227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables Sorbet strict type checking for several cask-related files (cask/tab.rb, cask/pkg.rb, cask/staged.rb, and cask/utils.rb) as part of the broader effort to add strict typing across the Homebrew codebase. The changes add explicit type signatures to methods, properly annotate memoized instance variables, and make related adjustments to ensure type safety.
Key changes:
- Upgraded type annotations from
typed: truetotyped: strictin cask utility files - Added explicit Sorbet method signatures throughout the modified files
- Replaced direct instance variable access with
attr_readeraccessors to support strict typing
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
Library/Homebrew/cask/utils.rb |
Enabled strict typing, added method signatures for permission management utilities, changed dir.writable? to dir&.writable? for nil safety |
Library/Homebrew/cask/tab.rb |
Enabled strict typing, added signature for runtime_deps_hash method |
Library/Homebrew/cask/staged.rb |
Enabled strict typing, changed instance variable references to use cask and command accessors |
Library/Homebrew/cask/pkg.rb |
Enabled strict typing, added T.let annotations to memoized instance variables, added method signatures |
Library/Homebrew/unversioned_cask_checker.rb |
Added Pathname() conversion in ensure blocks for type safety when calling gain_permissions_remove |
Library/Homebrew/cask/installer.rb |
Changed T::Class[SystemCommand] to T.class_of(SystemCommand) for consistency |
Library/Homebrew/cask/dsl/base.rb |
Added explicit attr_reader signatures for cask and command to support strict typing |
Library/Homebrew/cask/artifact/abstract_uninstall.rb |
Added Pathname() conversion for path parameter passed to gain_permissions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Rylan12
approved these changes
Dec 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?Part of
typed: strictin all (non-package) files in Homebrew organisation #17297