cmd/update-report: tap migrate installed formulae #21224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes formula-to-cask migration handling and adds support for 3rd-party tap migrations within the same repository. The changes ensure that migrated formulae are properly detected and processed without being incorrectly reported as deleted.
Key Changes:
- Introduces a new report key
:Tto track deleted formulae that have tap migrations, preventing them from being incorrectly reported as deletions - Adds support for same-tap migrations (e.g.,
{ "old-formula": "new-cask" }within the same tap) - Improves formula-to-cask migration detection and user messaging
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3 tasks
69a5f43 to
72038f6
Compare
MikeMcQuaid
approved these changes
Dec 13, 2025
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Thanks again again @cho-m!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?Fix formula-to-cask migration handling after ae43415fb4d
Also fix 3rd-party tap migrations within same repo when using either
{ <name>: <same-tap> }or{ <name>: <name> }