cask/installer: add workaround for language URLs #21218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a workaround to support concurrent installs for casks with language-specific URLs when using the JSON API. The change modifies the download enqueueing logic to handle casks that require the full caskfile to be loaded.
Key changes:
- Added conditional logic to detect casks with language-specific URLs
- Synchronously loads cask source for language-specific casks before enqueueing downloads
- Maintains async behavior for casks without language specifications
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MikeMcQuaid
approved these changes
Dec 12, 2025
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Thanks @cho-m! Could you open an issue to track this FIXME at some point?
The relevant logic should be porting the load_cask_from_source_api! logic to use the download queue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?For now, just add a quick fix to support concurrent installs using JSON API for casks with language specific URLs.
Leaving a FIXME comment as this blocks the main process while downloading Cask source which doesn't align with our usage of download queue.
Ideally should be handled asynchronously.
Fixes #21094