fix: Don't abort an install if a dangling tracking link exists #21213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every once in a while a user runs `brew install --overwrite FORMULA` and gets the error ``` Error: No such file or directory - /opt/homebrew/var/homebrew/linked/sq-satoolbox ``` The error is raised from [Library/Homebrew/keg.rb:105](https://github.com/Homebrew/brew/blob/51b612b63b86fbb0fe4ee39b8756c7fb05d4e964/Library/Homebrew/keg.rb#L105) which is in a call stack trying to tell you that the formula is already linked. But I'm suggesting we should not consider it be linked when the symlink is dangling. `brew install` will [remediate the situation correectly](https://github.com/Homebrew/brew/blob/51b612b63b86fbb0fe4ee39b8756c7fb05d4e964/Library/Homebrew/formula_installer.rb#L1161-L1164) anyway.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where brew install --overwrite would fail with "No such file or directory" errors when a dangling tracking link exists in /opt/homebrew/var/homebrew/linked/. The fix changes the Formula#linked? method to use exist? instead of symlink?, which properly treats dangling symlinks as "not linked" rather than causing errors downstream.
Key changes:
- Modified
Formula#linked?to useexist?check instead ofsymlink?to handle dangling symlinks correctly - This prevents
Keg.for()from being called on non-existent paths, avoiding the ENOENT error - The change aligns with the existing pattern where
Keg#linked?checks for both symlink existence and directory validity
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every once in a while a user runs
brew install --overwrite FORMULAand gets the errorThe error is raised from Library/Homebrew/keg.rb:105 which is in a call stack trying to tell you that the formula is already linked.
But I'm suggesting we should not consider it be linked when the symlink is dangling.
brew installwill remediate the situation correectly anyway.brew lgtm(style, typechecking and tests) with your changes locally?