tests: speed up cask tests #21210
Merged
tests: speed up cask tests #21210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR continues the test performance optimization effort started in PR #20493 by replacing additional DMG-based cask fixtures with ZIP-based fixtures in tests that require cask installation. ZIP files are significantly faster to extract than DMG files, which need to be mounted first, leading to faster test execution.
Key changes:
- Updated
with-depends-on-caskto depend onlocal-transmission-zipinstead oflocal-transmission - Changed
will-fail-if-upgradedfixture to use ZIP format with correct SHA256 hash - Updated test reference in
list_spec.rbto use the ZIP variant
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Library/Homebrew/test/support/fixtures/cask/Casks/with-depends-on-cask.rb | Updated dependency reference from local-transmission (DMG) to local-transmission-zip (ZIP) to speed up dependency installation tests |
| Library/Homebrew/test/support/fixtures/cask/Casks/will-fail-if-upgraded.rb | Changed URL from DMG to ZIP format and updated SHA256 hash to match the ZIP file for faster upgrade failure tests |
| Library/Homebrew/test/cask/list_spec.rb | Updated test fixture reference to use local-transmission-zip for faster test execution in file listing tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
a6d992e to
e149e29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?For the same reasons as explained in #20493 - use
zipinstead ofdmgin some additional instances that require cask installation.